Repository navigation
DX-128331: Backport JarBuild fix for new GitHub runner images (#42) - #45
Draft
victor6567758 wants to merge 2 commits into
Draft
victor6567758 wants to merge 2 commits into
victor6567758 wants to merge 2 commits into
Conversation
victor6567758
force-pushed
the
DX-128331-jarbuild-macos-fix
branch
from
November 14, 2026 14:52
b1395dc to
bfa4d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #42 to dremio_27.0_26_20.
Changes
-Dlz4_SOURCE=BUNDLED). Without it, theJNI macosjob fails archerycheck-dependenciesbecauseliblz4is found inlibarrow_dataset_jni.dylib.ubuntu-24.04with Temurin Java 17 pinned.Why the runner and Java pins are needed
The first version of this PR carried only the lz4 line. JarBuild run 43607601056 (https://github.com/victor6567758/arrow-java/actions/runs/43607601056) then failed in the Binaries job (https://github.com/victor6567758/arrow-java/actions/runs/43607601056/job/132524427663):
ubuntu-latestnow resolves to Ubuntu 26.04, whose default Java is 25, and google-java-format 1.17.0 does not handle it (see #42). Pinning Java 17 andubuntu-24.04is the same fix as #42.gh api repos/victor6567758/arrow-java/actions/jobs/132524427663/logs > binaries-old.loggrep -n -m 5 -iE "Image: |Version: 2|Operating System|ubuntu" binaries-old.loggrep -n -m 5 -iE "JAVA_HOME|Java version|OpenJDK|Maven home|Java home" binaries-old.logOnly #42's runner and Java 17 edits were copied. This branch's workflow differs from dremio_27.0_23_19 (it has extra abseil and flight steps), so the file is not a verbatim copy.
Test plan
gh workflow run jarbuild.yml --repo victor6567758/arrow-java --ref DX-128331-jarbuild-macos-fix -f arrow_repo=dremio/arrow -f arrow_branch=dremio_27.0_26_20 -f release_tag_name=v19.1.0-bf792fa-d12cc46