Skip to content

DX-128331: Backport JarBuild fix for new GitHub runner images (#42) - #45

Draft
victor6567758 wants to merge 2 commits into
dremio:dremio_27.0_26_20from
victor6567758:DX-128331-jarbuild-macos-fix
Draft

victor6567758 wants to merge 2 commits into
dremio:dremio_27.0_26_20from
victor6567758:DX-128331-jarbuild-macos-fix

Conversation

@victor6567758

@victor6567758 victor6567758 commented Nov 14, 2026 •

Copy link
Copy Markdown

Backport of #42 to dremio_27.0_26_20.

Changes

  • Bundle lz4 in the macOS JNI build (-Dlz4_SOURCE=BUNDLED). Without it, the JNI macos job fails archery check-dependencies because liblz4 is found in libarrow_dataset_jni.dylib.
  • Run Binaries and Verify on ubuntu-24.04 with Temurin Java 17 pinned.

Why the runner and Java pins are needed

The first version of this PR carried only the lz4 line. JarBuild run 43607601056 (https://github.com/victor6567758/arrow-java/actions/runs/43607601056) then failed in the Binaries job (https://github.com/victor6567758/arrow-java/actions/runs/43607601056/job/132524427663):

  Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:3.10.3:check (spotless-check) on project arrow-gandiva                                                                                                                                                                                         
  DecimalTypeUtil.java: the formatter wants a blank line before the `///` comment                                                                                                                                                                                                                                   

ubuntu-latest now resolves to Ubuntu 26.04, whose default Java is 25, and google-java-format 1.17.0 does not handle it (see #42). Pinning Java 17 and ubuntu-24.04 is the same fix as #42.

gh api repos/victor6567758/arrow-java/actions/jobs/132524427663/logs > binaries-old.log
grep -n -m 5 -iE "Image: |Version: 2|Operating System|ubuntu" binaries-old.log
grep -n -m 5 -iE "JAVA_HOME|Java version|OpenJDK|Maven home|Java home" binaries-old.log

Only #42's runner and Java 17 edits were copied. This branch's workflow differs from dremio_27.0_23_19 (it has extra abseil and flight steps), so the file is not a verbatim copy.

Test plan

  • gh workflow run jarbuild.yml --repo victor6567758/arrow-java --ref DX-128331-jarbuild-macos-fix -f arrow_repo=dremio/arrow -f arrow_branch=dremio_27.0_26_20 -f release_tag_name=v19.1.0-bf792fa-d12cc46

@victor6567758
victor6567758 requested a review from lriggs November 14, 2026 14:29
@victor6567758
victor6567758 force-pushed the DX-128331-jarbuild-macos-fix branch from b1395dc to bfa4d90 Compare November 14, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants